feat: contract to pay someone #11
Conversation
dckc
force-pushed
the
dc-swap-contract
branch
from
c7e72f9 to
3d6685e
Compare
dckc
force-pushed
the
dc-pay-contract
branch
from
74a9f6d to
98f9428
Compare
dckc
force-pushed
the
dc-pay-contract
branch
from
9e3d865 to
cfb3176
Compare
contract/src/postalSvc.js
Outdated
| }; | ||
|
|
||
| const publicFacet = Far('postalSvc', { | ||
| lookup: (...path) => E(namesByAddress).lookup(...path), |
There was a problem hiding this comment.
Why is this on the publicFacet? Is it part of the postalService purpose to make that available?
There was a problem hiding this comment.
yes; it's intended for use by other contracts: rather than taking namesByAddress as a term or privateArg, they can take the postalService instance
dckc
force-pushed
the
dc-pay-contract
branch
9 times, most recently
from
fc97a69 to
5172ccd
Compare
| } = postalPowers; | ||
| const { | ||
| // separate line for bundling | ||
| bundleID = Fail`no bundleID`, |
There was a problem hiding this comment.
Why? What does this do when passed to installBundleID()?
Why does bundllng want separate lines?
There was a problem hiding this comment.
The design in #16 is that there are 2 cases:
- in an ava tests, the caller supplies the
bundleIDin theconfigarg. - for deployment, this line gets replaced by
bundleID = ${JSON.stringify(b1-${bundle.endoZipBase64Sha512})},. See configureBundleID
For this PR, I punted the comment.
| /** | ||
| * @file core eval script* to start the postalService contract. | ||
| * | ||
| * * see rollup.config.mjs to make a script from this file. |
There was a problem hiding this comment.
Where is rollup.config.mjs?
There was a problem hiding this comment.
oops... . good catch... it's in..
I have a stack of PRs, and I keep changing my mind about what goes in which layer.
There was a problem hiding this comment.
I punted this note, along with batchQuery, makeHttpClient, marshalTables, and queryKit to #16.
A couple parts of queryKit belong here; they're in name-service-client.js.
dckc
force-pushed
the
dc-pay-contract
branch
2 times, most recently
from
64cc33d to
06a2402
Compare
- not deprecated - permit tweak, handle undefined config - ATOM not available from consume.issuer - move type burden to callee
- chore: purseNotifer -> purseUpdates - chore: prune starter, launcher actors - getPayoutAmounts
- test: contract instance is available - separate tests for runCoreEval etc. - start using CapData across vats - makeNameProxy for A.brand.ATOM - refactor agoricNames - real addresses - move initial balances into provisionSmartWallet, since we can't access ERTP mints in the e2e case - concise dockerExec - t.log for bundles, core eval - WIP: leave CapData to another level WIP: revert e2e postalSvc testing
Co-authored-by: Chris Hibbert <[email protected]>
refs
Page 2 - How to pay Someone documentation#941
contract: swap, pay, vote #9
contract
wallet level test
DRAFT (FYI @LuqiPan @Chris-Hibbert ) until:
mostly verbatim port of https://github.com/agoric-labs/ag-power-tools/blob/dc-launchpad/contract/test/test-postalSvc.js